Set context for shortcuts in ConsoleWidget #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this commit does what you think it does. It just deletes almost all of console_widget.py |
|
I'm sorry. I was trying the new editor of GitHub and seems like one of my browser plugins + the editor created some problems. I pushed the correct changes, now. Thanks! |
|
Works for me, OSX and Windows 7. |
|
These shortcuts should never have been added to ConsoleWidget in the first place, as shortcuts for printing and saving are an application-level matter. At some point, they should be moved out of ConsoleWidget and into QtConsoleApp. I don't have time to refactor this now, though, so I'm going to merge this. Thanks for the fix, @punchagan. |
epatters
added a commit
that referenced
this pull request
Sep 7, 2011
Set context for shortcuts in ConsoleWidget
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Set context for shortcuts in ConsoleWidget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of
Qt.WindowShortcutcauses a problem when IPython is embedded as a widget in other applications.Setting the shortcut context to
Qt.WidgetWithChildrenShortcut